systems crate #3472
Merged
systems crate #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
==========================================
- Coverage 54.51% 54.51% -0.01%
==========================================
Files 323 323
Lines 113288 113277 -11
==========================================
- Hits 61762 61751 -11
Misses 51526 51526 ☔ View full report in Codecov by Sentry. |
sug0
previously approved these changes
Jul 8, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
0e1db34
to
496b964
Compare
tzemanovic
added a commit
that referenced
this pull request
Jul 9, 2024
tzemanovic
added a commit
that referenced
this pull request
Jul 9, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
e19acd3
to
3793519
Compare
tzemanovic
added a commit
that referenced
this pull request
Jul 9, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
3793519
to
105183a
Compare
tzemanovic
added a commit
that referenced
this pull request
Jul 11, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
105183a
to
b9a1d0c
Compare
tzemanovic
added a commit
that referenced
this pull request
Jul 29, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
b9a1d0c
to
48149ca
Compare
tzemanovic
added a commit
that referenced
this pull request
Jul 29, 2024
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
48149ca
to
a4e50d7
Compare
Closed
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@tzemanovic @Fraccaman the changelog ci job is failing for some reason |
it should be fixed from #3559 but the base of this PR doesn't have this included |
|
https://github.com/Mergifyio rebase |
☑️ Nothing to do
|
tzemanovic
force-pushed
the
tomas/systems-crate
branch
from
a4e50d7
to
c64c7aa
Compare
sug0
approved these changes
Jul 30, 2024
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding a new systems crate to contain the abstract interfaces, previously added to core crate in the base PR. Also switched to use the concrete storage error and result type instead of the generic associated type which reduces the amount of typing needed one the caller side.
Updated dep graph
Indicate on which release or other PRs this topic is based on
Depends-On: #3402
Checklist before merging to
draft